Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using update_form on a custom form with duplicate fields #296

Open
spwoodcock opened this issue Sep 11, 2024 · 0 comments
Open

Using update_form on a custom form with duplicate fields #296

spwoodcock opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Sep 11, 2024

Describe the bug

  • We have a mandatory_fields.xlsx XLSForm.

  • If this is merged via update_forms with a custom form that contains duplicate fields, then we get some duplicate columns.

  • For example the mandatory_fields.xls contains the status field. The current buildings.xls also contains a status field.

  • When these forms are merged, we get a duplicate save_to column called save_to.1:

    image

To Reproduce

  • Run update_form.merge_sheets on buildings.xls in this repo.
  • Save the output to a file and view.

Expected behavior

  • We should warn users they have a duplicate field when running the function.
  • Ideally we return an error and ask them to rename / remove the field.
  • In the end, the mandatory forms field should take precedence.

Additional context

  • The form still works fine with the save_to.1 column.
  • This isn't high priority as it doesn't break anything (as far as I am aware).
@spwoodcock spwoodcock added the bug Something isn't working label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants