Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payslip Deductions #356

Open
loanduong02 opened this issue Sep 26, 2024 · 22 comments
Open

Payslip Deductions #356

loanduong02 opened this issue Sep 26, 2024 · 22 comments

Comments

@loanduong02
Copy link

Bug Report

Description

I added the deductions but the total shows only social insurance and the other 2 are not calculated.
image
image

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,
Can you please send the screenshot of the deduction form that you have set up?

With Regards,
Team Horilla

@loanduong02
Copy link
Author

@horilla-opensource
my deduction form
image

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,
Sorry for the confusion. Can you please send the screenshot of the deduction form in edit mode?

@loanduong02
Copy link
Author

@horilla-opensource
image

@horilla-opensource
Copy link
Owner

Bug Report

Description

I added the deductions but the total shows only social insurance and the other 2 are not calculated. image image

Hi @loanduong02 ,

Can we confirm if the payroll is generated for the user Loan Duong Anh ?

With Regards,
Team Horilla

@loanduong02
Copy link
Author

@horilla-opensource
thanks u I found the solution by changing the options

@loanduong02
Copy link
Author

loanduong02 commented Oct 1, 2024

@horilla-opensource
when i create a deduction at number 1 in august but when i create payslip in september that deduction appears again and i dont want deduction number 2 to appear in september i think just create separate additional deduction for each month
image
image

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,

The fix has been committed to the master branch. Please pull the latest code and test it out.

With Regards,
Team Horilla

@loanduong02
Copy link
Author

thanks @horilla-opensource that problem has been solved
but when i choose NET PAY the values ​​do not change
image
image
On the contrary, when I choose gross pay, the values ​​change.
image
image

@loanduong02
Copy link
Author

hi @horilla-opensource do you have any way to solve this problem

horilla-opensource added a commit that referenced this issue Oct 3, 2024
@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,
The solution is updated in the latest commit. Please check with the latest code.

@loanduong02
Copy link
Author

loanduong02 commented Oct 3, 2024

hi @horilla-opensource
This is the first payslip when I created it.
image
I still don't see any change when I add deduction like video
https://github.com/user-attachments/assets/905ef92c-cec5-459f-8c31-6bf1a34f82b4

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,
Can you try to create a fresh new payslip and confirm whether the issue is occurring in that also as we are not able to reproduce the issue at our end ?

@loanduong02
Copy link
Author

hi @horilla-opensource
I created a new payslip in October and added deductions to that payslip but still nothing changed
https://github.com/user-attachments/assets/2eedacb7-3b27-449a-9929-d93724d809bb

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,
Can you confirm whether your git head is the lastest head of the master branch of the repository?

@loanduong02
Copy link
Author

loanduong02 commented Oct 4, 2024

hi @horilla-opensource
I added the edits like what you changed in fix 356 in 2 files methods.py and component_views.py in payroll folder
In the allowance section I still added and the calculations were correct but in the deduction section the values ​​did not change.
I want when I refresh the page the total deduction to be recalculated if I have any additional deductions
https://github.com/user-attachments/assets/6e7fb2f2-5b6b-4474-b0c3-f9b62d20b25b

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,
Can we connect on a call to discuss this?

With Regards,
Team Horilla

@loanduong02
Copy link
Author

loanduong02 commented Oct 9, 2024

hi @horilla-opensource how can i contact. but my english communication is not good maybe only written communication.
Do you understand my description above?

@loanduong02
Copy link
Author

@horilla-opensource Here is the description of the error which i hope you fix soon. thank you very much
https://github.com/user-attachments/assets/6262df3a-7f73-4d94-96aa-e9379f70cada

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,

From the screen recording you have shared, it seems that the code is not the latest code base fix we have added. Please pull the latest code and try again and let us know if it's still has issues.

With Regards,
Team Horilla

@loanduong02
Copy link
Author

loanduong02 commented Oct 10, 2024

Hi @horilla-opensource There is still a problem with the total deduction.
image

@horilla-opensource
Copy link
Owner

Hi @loanduong02 ,

If the deductions are update compensation then those deductions wont be calculated to the total deductions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants