Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer OTLP object fields over attributes on ingest #208

Open
cartermp opened this issue Aug 10, 2023 · 1 comment
Open

Prefer OTLP object fields over attributes on ingest #208

cartermp opened this issue Aug 10, 2023 · 1 comment
Labels
type: bug Something isn't working type: enhancement New feature or request

Comments

@cartermp
Copy link
Member

cartermp commented Aug 10, 2023

Today, we can overwrite actual OTLP fields with attributes that have the same name. For example, name is how Honeycomb tracks a span name, but if you have a custom field called name, then this overrides the span's name on the event that we create.

Because of how Honeycomb's event model works, events are just a collection of fields, and we don't distinguish between those that came from OTLP vs. those that are attributes. And in our code, we first copy over the OTLP fields, and then the attributes. The attributes can override.

We should copy over the OTLP fields at the end instead. This has the downside of technically being a breaking change -- however, the reason for overriding these names may not be intentional by users.

@cartermp cartermp added the type: enhancement New feature or request label Aug 10, 2023
@bixu
Copy link

bixu commented Aug 21, 2024

Using the K8s Attributes Processor from the Collector, we had a team add a name label the pods of a service. This resulted in all spans being named the pod name in traces, because the Processor had copied the pod label to a resource attribute, and then in the UI that resource attribute, name, overwrote the name being sent as a Span attribute by the service.

@kentquirk kentquirk added the type: bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants