Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we reliably determine service.name to support service maps? #168

Open
MikeGoldsmith opened this issue Sep 12, 2023 · 1 comment
Open

Can we reliably determine service.name to support service maps? #168

MikeGoldsmith opened this issue Sep 12, 2023 · 1 comment
Labels
type: enhancement New feature or request

Comments

@MikeGoldsmith
Copy link
Contributor

MikeGoldsmith commented Sep 12, 2023 •
edited by robbkidd
Loading

If we can detect the k8s resource type (deployment, deamonset, etc) and set it's value as the event's service.name, we might be able to populate with service map.

NOTE: We currently generate events for both pods and services, which means it looks like we duplicate events. Maybe we should limit the types of resources we monitor / generate events for.
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Sep 12, 2023
@robbkidd robbkidd changed the title Detect and record k8s resource type and set service.name Can we reliably determine service.name to support service maps? Sep 20, 2023
@robbkidd
Copy link
Member

robbkidd commented Sep 20, 2023 •
edited
Loading

Will setting service.name on events override the agents' configured dataset for events?

Same for when we switch to OTLP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robbkidd @MikeGoldsmith