Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can buildevents cmd capture stdout / stderr on failed spans? #207

Open
estraph opened this issue Jan 8, 2024 · 1 comment
Open

can buildevents cmd capture stdout / stderr on failed spans? #207

estraph opened this issue Jan 8, 2024 · 1 comment
Labels
type: enhancement New feature or request

Comments

@estraph
Copy link

estraph commented Jan 8, 2024

Is your feature request related to a problem? Please describe.
I've been trying out buildevents in GitHub actions and have been using buildevents cmd to run a number of shell commands, and send them as spans to Honeycomb. When a span has an error, it seems that while the exit code is captured as a span attribute, the actual error output (stdout or stderr) is not.

Describe the solution you'd like
From using other opentelelemtry and honeycomb libraries it seems useful to include the error message on the span. I would love to see the cmd command not just pass through stdout and stderr but also include them on a the span if the command exits with an error.

Describe alternatives you've considered
I've very briefly considered using tee to output errors to a file, detecting non-zero exit codes and including the output as an attribute via the BUILDEVENT_FILE. This would add a lot of boilerplate to my workflows, though - which are already a bit bloated through the instrumentation as it is.

Additional context
I've been enjoying this tool otherwise, thanks for making a great product and helping to instrument CI 🚀

@estraph estraph added the type: enhancement New feature or request label Jan 8, 2024
@brookesargent
Copy link
Contributor

Thank you for submitting this issue, @estraph! This is a great suggestion, I'll move it along to be prioritized in our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants