-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link from clade visualization to variant pages #272
Comments
Hi @jamesscottbrown - this is a cool suggestion! We do generate our own version of the SVG for CoVariants, but, yes, it's essentially from the repo you linked. The person to look at feasibility of this would be @ivan-aksamentov - I'm afraid I know nothing about adding such tags within the SVG. Ivan I'd say this isn't high priority but would be cool if possible and wouldn't take too much work. At the moment my entry in |
The svg file is used in Nextclade (main page) and might also be used elsewhere, so the One might add unique If interactivity is needed, I think that the the SVG file is a wrong tool to do the job. We better just take the clades.json and implement a proper React component then. This is an investment - the positioning of nodes and drawing the edges would be somewhat challenging, but maybe we could hook into the positions calculated the existing implementation (based on d3)? With a proper React implementation more features and eye candy can be added, and clicks would not trigger full-page reload. |
Thanks for chipping in @ivan-aksamentov ! Sounds like this is likely more trouble than it's worth. While it would be nice to have, the links to the variants are just nextdoor in the buttons, so I don't think this really impacts usability of the site. I'll leave this in case someone curious wants to give it a go, but I think we can put it on the back burner for CoVariants for now, and see if progress in the |
The homepage now includes a nice tree showing the relationship between the variants.
It would be nice if a user could click on the circular nodes or text labels to navigate to the corresponding variant page.
This can be easily done by adding
a
tags within the SVG. However, there are two data-flow challenges:The text was updated successfully, but these errors were encountered: