Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose changes in block collection's video block #89

Open
yugandhar02 opened this issue Aug 14, 2024 · 0 comments
Open

Propose changes in block collection's video block #89

yugandhar02 opened this issue Aug 14, 2024 · 0 comments
Assignees
@yugandhar02

Comments

@yugandhar02
Copy link

We recently added new video block which has following support

  1. Renders poster image and delays video loading resulting into 100 LHS score even with video as hero banner
  2. Have 3 different variants
    • Modal
    • Inline
    • Hero
  3. Auto pause videos once they go out of viewport
  4. Customisation

The new video block can be located here
https://github.com/hlxsites/franklin-assets-selector/tree/main/blocks/video
@yugandhar02 yugandhar02 self-assigned this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yugandhar02 yugandhar02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yugandhar02