Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to provide custom logo icons to render in the title bar #63

Open
hholzgra opened this issue Jul 3, 2022 · 1 comment
Open

Allow to provide custom logo icons to render in the title bar #63

hholzgra opened this issue Jul 3, 2022 · 1 comment

Comments

@hholzgra
Copy link
Owner

hholzgra commented Jul 3, 2022

Right now there's only support for an OpenStreetMap icon (always present), and a "Refugees Welcome" icon used by the neighborhood map application.

It should be possible to add a custom SVG icon to be rendered in addition, or as a replacement for, the OSM icon.

In addition to a local file path a HTTP download URL should also be supported
@hholzgra
Copy link
Owner Author

hholzgra commented Oct 23, 2022 •
edited
Loading

  • refactor code / remove duplicate code
  • support bundled:filename.svg syntax for bundled logo images
  • fetch logo and extra_logo from settings (URLs no longer hard coded)
  • remove special handling for neighborhood POI maps
  • support bitmap formats like PNG and JPEG, too, not just SVG
  • support remote http:/https: URLs in addition to local files
  • add command line options --logo and --extra-logo

@hholzgra hholzgra changed the title Allow to provice custom icons to render in the title bar Allow to provice custom logo icons to render in the title bar Oct 23, 2022
@hholzgra hholzgra changed the title Allow to provice custom logo icons to render in the title bar Allow to provide custom logo icons to render in the title bar Oct 23, 2022
hholzgra added a commit that referenced this issue Oct 23, 2022
@hholzgra
logo code refactoring - Issue #63 (work in progress)
39ec360 
- refactored to no longer have duplicate code for OSM and extra logo
- allow for arbitrary SVG logo files, not just the two bundled ones
- allow to refer to bundled logos using 'bundled:filename.svg' URLs
hholzgra added a commit that referenced this issue Oct 23, 2022
@hholzgra
Remove old logo methods - Issue #63 (work in progress)
7c73d4e
hholzgra added a commit that referenced this issue Oct 23, 2022
@hholzgra
get logo URL from settings, not hard coded - Issue #63 (WiP)
f45f361 
- the logo and extra_logo are now fetched from the settings
- logo defaults to 'builtin:osm-logo.svg'
- extra logo defaults to None
- for now there's still special handling for the extra logo
  for neighborhood maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hholzgra