Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapd-crossfilter stopped working after upgrading to babel7 and webpack4 #80

Open
4 tasks
sandipp opened this issue Mar 29, 2019 · 3 comments
Open
4 tasks

Comments

@sandipp
Copy link

sandipp commented Mar 29, 2019

🪲 bug

  • Operating System and version: OS X 10.14.4
  • Browser and version: Chrome 73 on macOS (Mojave)
  • Steps to reproduce (including dashboard link): Upgraded React application configuration by using newer version of babel7 and webpack4
  • Description of issue: mapd-crossfilter is failing with the following issue-
TypeError: Cannot set property 'resultCache' of undefined 
(function (exports) {
  crossfilter.version = "1.3.11";
  exports.resultCache = resultCache;
...

This is my babel configuration -

"babel": {
    "plugins": [
      "add-module-exports",
      "@babel/plugin-syntax-dynamic-import",
      [
        "@babel/plugin-proposal-decorators",
        {
          "legacy": true
        }
      ],
      [
        "@babel/plugin-proposal-class-properties",
        {
          "loose": false
        }
      ]
    ],
    "presets": [
      [
        "@babel/preset-env",
        {
          "modules": false
        }
      ],
      [
        "react-app",
        {
          "helpers": false,
          "absoluteRuntime": false
        }
      ]
    ]

  }

And this is my webpack configuration -

https://gist.github.com/sandipp/282bbbc1d23e6e9c2d8e2b01dc1077d7

@paradom
Copy link

paradom commented May 17, 2020

Did you ever find a way to get around this issue? I am running into the same thing

@sandipp
Copy link
Author

sandipp commented May 17, 2020

@paradom Yeah, I did hacky fix changing into the library exports function.

@paradom
Copy link

paradom commented May 17, 2020

I am not really sure what you mean, would it be possible to show me what you changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants