Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

div commentary in HGV files #45

Open
jcowey opened this issue Mar 14, 2022 · 0 comments
Open

div commentary in HGV files #45

jcowey opened this issue Mar 14, 2022 · 0 comments
Assignees

Comments

@jcowey
Copy link
Collaborator

jcowey commented Mar 14, 2022

Since the field Bemerkungen (in HGV) / commentary in papyri.info has always belonged to a standard HGV record, I have added a new row to (why I forgot about it I am not sure, anyway it is now needed in a submission)

https://github.com/jcowey/P3/blob/master/guidelines/metadataMask.md

with the commit: jcowey/P3@45c423c

This would require at least an update to

https://github.com/hcayless/P3-processing/blob/main/xslt/process-tei-2.xsl

Using e.g. https://github.com/papyri/idp.data/blob/master/HGV_meta_EpiDoc/HGV90/89155.xml#L77-L79

as a model, after https://github.com/hcayless/P3-processing/blob/main/xslt/process-tei-2.xsl#L353

I think you will need to incorporate something like

<xsl:if test="fn:has-value(t:table[1],'Commentary')"><div type="commentary" subtype="general">
  <p><xsl:value-of select="fn:get-value(t:table[1],'Commentary')"/></p>
</div></xsl:if>

That may suffice (if it is correct, please check), but maybe other places in the code also require attention.

@jcowey jcowey changed the title Div commentary in HGV files div commentary in HGV files Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants