Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove filter when click on an active filter button #34

Open
metalvegetarianoprogresivo opened this issue Oct 16, 2019 · 1 comment
Labels
bug Something isn't working js Any new issue/pr with JS react ui Changes for the UI

Comments

@metalvegetarianoprogresivo
Copy link
Contributor

When adding a new filter using the FilterButton, the new buttons highlight indicating it is active. But when clicking it again does not remove the filter.

image

Acceptance criteria:
Click on an active filter button should remove the filter.

@metalvegetarianoprogresivo metalvegetarianoprogresivo added bug Something isn't working js Any new issue/pr with JS ui Changes for the UI react labels Oct 16, 2019
RobertoOchoaAldana added a commit to RobertoOchoaAldana/dbs-scraper that referenced this issue Oct 18, 2019
Xotl pushed a commit that referenced this issue Nov 12, 2019
* adding functionality to filter buttons

* adding EOF lines

* Fixing issue with color filters

* resolve issue #34, now you can click on an active filter button and remove the filter

* fixing issue where comboEnergy was active and clicking on it wouldn't remove the filter

* resolve issue #32, now generic energy cost is displayed correctly

* Deleting semicolons, refactoring the filterbox file, adding hooks

* refactoring the method to create buttons

* added changes so when a filter by same field already exist it will add it as an or into the same filter, also added changes requested by irving

* deleting semicolons
@Jarv1193
Copy link
Contributor

Este también ya está resuelto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working js Any new issue/pr with JS react ui Changes for the UI
Projects
None yet
Development

No branches or pull requests

2 participants