Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out database url / credentials in config #233

Open
mahmoud opened this issue Apr 9, 2023 · 0 comments
Open

Factor out database url / credentials in config #233

mahmoud opened this issue Apr 9, 2023 · 0 comments

Comments

@mahmoud
Copy link
Member

mahmoud commented Apr 9, 2023

Per this phabricator ticket, if we allow the config to also support reading from a separate file, that will allow toolforge admins to rotate db passwords without worrying about modifying our prod config directly.

For ref, QuickCategories passes through kwargs for this: https://github.com/lucaswerkmeister/tool-quickcategories/blob/e27a219ad0b1ebec5d5af0393bc5d6dbc63ea13a/config.yaml.example#L6-L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant