Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group 0 #62

Open
alexyao2015 opened this issue Jan 7, 2021 · 3 comments
Open

Fix group 0 #62

alexyao2015 opened this issue Jan 7, 2021 · 3 comments
Labels
bug Something isn't working confirmed We know what should be done to resolve the issue

Comments

@alexyao2015
Copy link
Member

Describe the bug

Group 0 should modify all lights in all groups. Currently, group 0 gives an error since its not a registered group.

Steps to Reproduce

Expected behavior

group_conf = await self.config.async_get_storage_value("groups", group_id)

Properly handle group 0 by iterating through all enabled lights in all groups.

Logs

Hardware Info:

  • Architecture (Ex: x86, ARM):
  • Addon version (Ex: stable or dev):
    • Value of "tag_commit_or_branch" if using dev:
  • OS (Ex: Windows 10, Ubuntu Buster):
  • Hardware (Ex: PC, Raspberry Pi 1/2/3/Zero):

Additional context

@alexyao2015 alexyao2015 added the bug Something isn't working label Jan 8, 2021
@alexyao2015 alexyao2015 changed the title Implement Group 0 Fix groups Jan 10, 2021
@alexyao2015
Copy link
Member Author

Group 0 has some issues.
Group attributes are not complete. Still missing "action", "recycle", "sensors", "state".

@alexyao2015 alexyao2015 changed the title Fix groups Fix group 0 Jan 10, 2021
@alexyao2015
Copy link
Member Author

PUT /api/username/groups/0/action
with {'on': True}
results in an error

@github-actions
Copy link
Contributor

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed We know what should be done to resolve the issue
Projects
Development

No branches or pull requests

1 participant