Record skipped event data in events #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @maoe . Apparently this doesn't build with GHC 7.8.4. I'll fix this later. |
|
The changes look good to me. Could we add a test case to check the property? Regarding the build error with GHC 7.8.4, I'm personally fine with dropping support for it if the fix involves CPP. |
(first attempt)
We don't actually have roundtrip property until we fix #14 first -- I'll update the PR title and description. I wrote some ideas in #14 and I'm hoping to start working on it so let me know what you think. After #14 we can write hedgehog or QC based property tests. (I'm currently testing this branch by reading a 1G large .eventlog file and for every event testing the roundtrip property) |
osa1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch we record any skipped data of an event in
Event, to be ableto serialize
Events with skipped data as they were generated by GHC. This inturn gives us roundtrip property for more events (but not for all events, for
that we need to fix #14).
Fixes #41