Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm temporary directory is not cleaned up. #964

Open
matteriben opened this issue Sep 4, 2024 · 0 comments
Open

Helm temporary directory is not cleaned up. #964

matteriben opened this issue Sep 4, 2024 · 0 comments
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Pending Triage New issue that needs to be triaged by the team

Comments

@matteriben
Copy link
Contributor

matteriben commented Sep 4, 2024

Bill of Materials or CLI Version

No response

Execution Environment

JUnit Extensions

Slf4j Logging Implementation

None

To Reproduce

Use the helm client and notice it leaves temporary directories around with the helm executable in each.

Describe the bug

The helm client extracts the helm executable to a temporary directory, and this temporary directory is not cleaned up.

Describe the expected behavior

The temporary directory should be cleaned up.

Would be nice if client implemented AutoCloseable and cleaned up after itself inside close().

Whole JUnit/CLI Logs

N/A

Additional Context

Example directory name is HelmSoftwareLoader4512790602684642253 and it contains the helm executable.

The issue may be that File::deleteOnExit fails to remove a non-empty directory.

@matteriben matteriben added Bug A error that causes the feature to behave differently than what was expected based on design docs Pending Triage New issue that needs to be triaged by the team labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Pending Triage New issue that needs to be triaged by the team
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant