Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown and Linkify should not add nofollow to relative links and trusted domains #227

Open
jace opened this issue May 16, 2019 · 0 comments
Open

Markdown and Linkify should not add nofollow to relative links and trusted domains #227

jace opened this issue May 16, 2019 · 0 comments
Assignees
@jace
Labels
coaster.text enhancement

Comments

@jace
Copy link
Member

jace commented May 16, 2019

rel="nofollow" is currently added to all links by markdown and sanitize_html. It should not be added to:

  1. Relative links
  2. Trusted domains as specified in the app configuration, which requires both functions to consult current_app or to receive the domains as a parameter. If the latter, MarkdownColumn must pass this in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jace jace

Labels
coaster.text enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jace