Add buses logos #55
Merged
Add buses logos #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing operator_id - there are two different approaches to solve this issue: 1. add craco and load the images dynamically using require.context 2. use the second approach I commented in the code
- changed implementation of images loading
- load buses`logos according to its operator_id in `colorIcon`
NoamGaash
approved these changes
Sep 19, 2023
src/pages/Map.scss
Outdated
Comment on lines
13
to
15
| /*-webkit-mask-repeat: no-repeat; | ||
| -webkit-mask-position: center; | ||
| -webkit-mask-size: contain; | ||
| -webkit-mask-size: contain;*/ |
There was a problem hiding this comment.
remove comments where possible
|
@rzarviv please approve my latest commit to your PR |
|
@NoamGaash apparently I cannot approve your commit since I'm the creator of the PR, so I'll add a whitespace somewhere just to push it from my branch |
|
@rzarviv I meant I want your opinion, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicdirectory.close #32