Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement homepage design according to figma #421

Closed
BinaHovav opened this issue Jan 21, 2024 · 4 comments · Fixed by #762
Closed

Implement homepage design according to figma #421

BinaHovav opened this issue Jan 21, 2024 · 4 comments · Fixed by #762
Assignees
@itsoriki
Labels
CSS related to the design, without affecting business logic frontend frontend developers issue

Comments

@BinaHovav
Copy link
Collaborator

BinaHovav commented Jan 21, 2024 •
edited
Loading

The basic files and structure is in the project, now the need is to design it according to figma design.
In order to see the page on localhost, change the end of the path to 'home'.

Link to Figma design (still needs improvement but this is the basic) :
https://www.figma.com/file/0D6JxNw691wIstb0wuR5NW/DataBus-Design?type=design&mode=design&t=TtyNCSU8UuBthoOY-0
@BinaHovav BinaHovav added CSS related to the design, without affecting business logic frontend frontend developers issue labels Jan 21, 2024
@amabelleS
Copy link
Collaborator

amabelleS commented Feb 5, 2024 •
edited
Loading

Correct me if I'm wrong. The "לתרומות" in the side nav is supposed to be at the bottom of the screen, as the green footer.
The main content of the home page is supposed to be scrollable.

I can take this issue:)

@shootermv shootermv changed the title Design homepage according to figma design implement homepage design according to figma Feb 6, 2024
@itsoriki itsoriki changed the title implement homepage design according to figma Implement homepage design according to figma May 13, 2024
@itsoriki
Copy link
Collaborator

@amabelleS Hi, how is the mission going so far? Do you need any help?

@NoamGaash
Copy link
Member

@amabelleS let us know where are you standing and if you need any help! If you're still on this issue, please let us know and you'll be re-assigned
Thanks!

@itsoriki itsoriki self-assigned this May 21, 2024
@itsoriki
Copy link
Collaborator

Progress:

image

@itsoriki itsoriki mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsoriki itsoriki

Labels
CSS related to the design, without affecting business logic frontend frontend developers issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement homepage design according to figma hasadna/open-bus-map-search
4 participants
@NoamGaash @amabelleS @itsoriki @BinaHovav