Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible menu(at dashboard page) - make the collapse animation faster #254

Closed
xoRmalka opened this issue Nov 28, 2023 · 3 comments · Fixed by #255
Closed

Collapsible menu(at dashboard page) - make the collapse animation faster #254

xoRmalka opened this issue Nov 28, 2023 · 3 comments · Fixed by #255
Assignees

Comments

@xoRmalka
Copy link
Member

          @xoRmalka @shootermv it's already merge, so feel pree to open issue or another PR if needed

Originally posted by @NoamGaash in #215 (comment)

@NoamGaash
Copy link
Member

NoamGaash commented Nov 28, 2023

Hi @xoRmalka , thanks for opening this issue.
some ideas to make it easier for newcomers:

  • add a screenshot
  • describe the intended behaviour rather the observed one (i.e "make the collapse animation faster")
  • add labels

good luck 🌠

@xoRmalka xoRmalka changed the title The collapsible menu on the dashboard page opens and closes slowly Collapsible menu - make the collapse animation faster Nov 28, 2023
@NoamGaash NoamGaash linked a pull request Nov 28, 2023 that will close this issue
@shootermv shootermv changed the title Collapsible menu - make the collapse animation faster Collapsible menu(at dashboard page) - make the collapse animation faster Nov 29, 2023
@shootermv
Copy link
Collaborator

one thing i can assume as cause of slowness -
the resize of chart`s container which occurs when menu collapses -
makes the charts rerender multiple times (to adapt themselves to the width of container)

may be if we can handle the collapse animation start, and replace charts by skeletons during the collapsing animation - it will make the situation better?
so far is my idea

@xoRmalka
Copy link
Member Author

I found a solution. I'm updating the PR. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants