Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use newer torchtext APIs #122

Open
erip opened this issue Dec 27, 2021 · 2 comments
Open

Update examples to use newer torchtext APIs #122

erip opened this issue Dec 27, 2021 · 2 comments

Comments

@erip
Copy link
Contributor

erip commented Dec 27, 2021

I'm in the process of updating the pytorch benchmarks repo to use newer torchtext APIs. These benchmarks use an adapted version of this example notebook. If it makes sense, I'm happy to submit a PR to similarly update the examples here (and in other notebooks where relevant).

@srush
Copy link
Collaborator

srush commented Dec 28, 2021

Would love that.

@erip
Copy link
Contributor Author

erip commented Dec 28, 2021

Great. There are some caveats about parity between features from legacy torchtext APIs and new ones, but they likely won't be of consequence for this repo. The biggest change is how bucketing works intra-batch now that BucketIterator is gone. Once the current PR has gotten reviewed and lands I'll cut a PR here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants