Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APK release feedback #18

Open
KartikTalwar opened this issue Sep 2, 2014 · 9 comments
Open

New APK release feedback #18

KartikTalwar opened this issue Sep 2, 2014 · 9 comments

Comments

@KartikTalwar
Copy link
Member

  • The UI is really smooth - awesome!
  • Nice touch hexagon animations
  • I tried typing random letters on mentors search but it always returns a search result
    • How is a match being calculated?
    • can you remind me on what the search criteria is?
  • Can we have the gear logo with the htn text in the header bar (center aligned)
  • In the prizes section, can the Prizes heading be paragraphs as well (instead of bullets only)?
  • Can we see the team's contact info demo
  • wrt updates, I think the focus should be reversed. Currently the person who made the updates is bigger (font) than the message. It'll be literally just us posting messages so you'll keep seeing the first name. Can we take away all attention from the owner and make the actual post our focus.
  • Also realized that we need another sponsors section.
    • Can we add that tab and have the content be blank view
    • We can then put a url in firebase of the final sponsor montage (still confirming a few) and have it simply embed the image
@srcreigh
Copy link
Contributor

srcreigh commented Sep 2, 2014

  • it's doing fuzzy string matching on all the relevant data for each mentor---first and last names, each of their skills, and their company and searching on keystroke (this is doable since the data set is so small). in particular, the score for a mentor is the sum of e^( - levenshtein(query, token) ) for each token (i.e. first name, last name, skills, company). if you enter multiple keywords (i.e. "android facebook"), it splits them up into separate queries and accounts for that in the ranking
  • we were sorta going with what seems to be the new design guidelines for Android apps, which seems to be that there shouldn't be a logo in the actionbar.
  • do you mean like how we're displaying the skills in the mentors tab? I asked that question too and we thought the list looked better for real prize data, I'll see if we can make up some screenshots
  • we're still working on the actions and functions, as well as the UI to do with those things, of some of the cards/elements, including team. we'll come up with something that's a bit like what's currently in the mentors cards (sans functionality)---it'll show little icons to mean "when you tap the element, you'll get to choose to interact with the information these icons represent".
  • yeah. we've talked about the updates UI being a little off focused before. to make it easy to change, (think about iOS too, and deadlines are very quickly approaching) I suggest that we just start treating the name like a title, and the avatar like an opportunity for playfulness, with the HTN logo being default. this is the first time we've done this so we can iterate on it for next year.
  • that's easy to add. make sure that the final montage is oriented portrait-style, as that way it will look perfect in the regular case and half-decent in the alternate case (as opposed to bad when the phone is in portrait mode and perfect in the irregular case). on this note, if you have any other requests like this you'll have to make them literally now. the iOS deployment process means that we have to finalize iOS this week.

@moezbhatti
Copy link
Contributor

@KartikTalwar

Can we have the gear logo with the htn text in the header bar (center aligned)

Adding the logo makes the action bar too crowded, so that's why we removed it. It doesn't work well at all on smaller phones when there's multiple actions displayed at the top. And having it aligned left is the standard on android, center aligned is more of an iOS thing

In the prizes section, can the Prizes heading be paragraphs as well (instead of bullets only)?

What do you mean by this? Aren't the prize names all going to be less than one line anyway?

Can we see the team's contact info demo

I'll be working on this as soon as I get a chance

wrt updates, I think the focus should be reversed. Currently the person who made the updates is bigger (font) than the message. It'll be literally just us posting messages so you'll keep seeing the first name. Can we take away all attention from the owner and make the actual post our focus.

Very good point. I've got an idea in mind for an alternate layout, so I'll implement that shortly as well

@srcreigh
Copy link
Contributor

srcreigh commented Sep 2, 2014

What's your idea for the alternate layout, Moez? Keep in mind that we want to remain consistent with iOS with minimal work at this point.

@KartikTalwar
Copy link
Member Author

@srcreigh @moezbhatti

Adding the logo makes the action bar too crowded, so that's why we removed it. It doesn't work well at all on smaller phones when there's multiple actions displayed at the top. And having it aligned left is the standard on android, center aligned is more of an iOS thing

That's fair, The reason I mentioned it was because the padding on the left makes it seem weird (even though its aligned with the U in Updates). So either we made just the text center or add the logo on the left. I was trying to normalize it with spacing on left and right of the bar

it's doing fuzzy string matching on all the relevant data for each mentor

I asked because, if I type in 'sdfdsvcasvrg' I still see results. So should the expected behaviour be no results or they get ranked anyway?

What do you mean by this? Aren't the prize names all going to be less than one line anyway?

So a prize card has 2 headings, the company name (paragraph body) and then Prizes (list body) wanted to know if the prizes can also be a sentence/paragraph

Very good point. I've got an idea in mind for an alternate layout, so I'll implement that shortly as well

👍

  • For sponsor image, yes, we'll make sure its portrait and consider any dimensions if necessary
  • Finalizing design, yeah lets do it this week

@srcreigh
Copy link
Contributor

srcreigh commented Sep 2, 2014

I asked because, if I type in 'sdfdsvcasvrg' I still see results. So should the expected behaviour be no results or they get ranked anyway?

Oh, yeah. I can have things that rank below a certain threshold just not show up at all, which should fix this problem.

@srcreigh
Copy link
Contributor

srcreigh commented Sep 2, 2014

Adding the logo makes the action bar too crowded, so that's why we removed it. It doesn't work well at all on smaller phones when there's multiple actions displayed at the top. And having it aligned left is the standard on android, center aligned is more of an iOS thing

That's fair, The reason I mentioned it was because the padding on the left makes it seem weird (even though its aligned with the U in Updates). So either we made just the text center or add the logo on the left. I was trying to normalize it with spacing on left and right of the bar

Maybe it'll look better if the left margin of the text is the same as the bottom / top margin.

@sitefeng
Copy link

sitefeng commented Sep 4, 2014

Pretty solid design

@NimaVaziri
Copy link

Just tried the latest release. First impression: awesome, well done!

@srcreigh
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants