Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner is completely broken since resources dont exist currently #1386

Open
saumilthecode opened this issue Sep 19, 2024 · 9 comments · May be fixed by #1387
Open

Banner is completely broken since resources dont exist currently #1386

saumilthecode opened this issue Sep 19, 2024 · 9 comments · May be fixed by #1387

Comments

@saumilthecode
Copy link

saumilthecode commented Sep 19, 2024 •
edited
Loading

closes #1386

https://github.com/hackclub/banner

broken since nothing for 2023-2024 :p

gna jump into gimp to fix this

cookie
@saumilthecode
Copy link
Author

#1387

@saumilthecode saumilthecode linked a pull request Sep 19, 2024 that will close this issue
Open
@saumilthecode saumilthecode reopened this Sep 19, 2024
@saumilthecode
Copy link
Author

how do i link 🙏

@saumilthecode
Copy link
Author

closed by #1387

@saumilthecode
Copy link
Author

what
this is not working

@SkyfallWasTaken
Copy link
Contributor

@saumilthecode say “closes #1386” in the top level issue post

@saumilthecode saumilthecode changed the title the banner is completely broken since the svg dosent exist closes #1386 Sep 20, 2024
@saumilthecode
Copy link
Author

did it work

@saumilthecode
Copy link
Author

wait wrong one
this should be at the PR

@saumilthecode saumilthecode changed the title closes #1386 Banner is completely broken since resources dont exist currently Sep 20, 2024
@saumilthecode
Copy link
Author

oh lets gooo

@saumilthecode
Copy link
Author

this can prob be closed since i was told it needs to be reworked to pull from https://assets.hackclub.com/ instead of http://hackclub.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1386 add new banners for '23 and '24 saumilthecode/site
2 participants
@SkyfallWasTaken @saumilthecode