Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve nested group membership #17

Open
shackit opened this issue Jul 23, 2018 · 4 comments
Open

Retrieve nested group membership #17

shackit opened this issue Jul 23, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@shackit
Copy link
Contributor

shackit commented Jul 23, 2018

At the moment kube-ldap reads the direct group membership from the ldap user account. For example when binding to Microsoft Active Directory we retrieve the memberOf attribute. However, those groups could be members of other groups.

We have a situation where we could have multiple k8 clusters and we would like a default RBAC rule bound to a particular group. Within that group we would have other groups, Ops/InfoSec etc. Instead of having to manage multiple RoleBindings/ClusterRoleBindings for each cluster, we would like to leverage the one parent group.

@shackit
Copy link
Contributor Author

shackit commented Jul 23, 2018

I have attempted a patch for this issue on my fork, https://github.com/shackit/kube-ldap/tree/nested-ad-groups. I doubt this is a viable solution for all LDAP directories as it uses LDAP_MATCHING_RULE_IN_CHAIN "(member:1.2.840.113556.1.4.1941:=" + ldapObject.dn +")" This works pretty well for MS AD.

@juckerf
Copy link
Contributor

juckerf commented Jul 24, 2018

hm.. I like the idea of supporting nested group memberships.
however, in my opinion the most generic way would be to follow the memberOf (or whatever attribute is configured) values recursively. but this can probably be very costly and would introduce some new challenges (like detecting cycles etc.).

@juckerf juckerf added the enhancement New feature or request label Jul 24, 2018
@juckerf juckerf added this to the 2.0.0 milestone Mar 27, 2019
@juckerf juckerf removed this from the 2.0.0 milestone Jun 12, 2019
@juckerf
Copy link
Contributor

juckerf commented Jun 12, 2019

I removed this feature from the 2.0.0 milestone since I haven't found any generic and nice way to support nested group memberships.
Probably I will implement a method do support nested group memberships for Microsoft AD which can be activated via a config parameter.

@antoineozenne
Copy link

Have you find a solution ? I like this because it's very easy to use but I really need support of nested groups. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants