Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Shape.is_valid() to Shape.is_valid (a property) #710

Open
jdegenstein opened this issue Sep 24, 2024 · 1 comment
Open

change Shape.is_valid() to Shape.is_valid (a property) #710

jdegenstein opened this issue Sep 24, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@jdegenstein
Copy link
Collaborator

Currently Shape.is_manifold is a property, I propose changing Shape.is_valid() from a method to a property Shape.is_valid
@gumyr gumyr added the duplicate This issue or pull request already exists label Sep 24, 2024
@gumyr
Copy link
Owner

gumyr commented Sep 24, 2024

Duplicate of #435

@gumyr gumyr marked this as a duplicate of #435 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdegenstein @gumyr