Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File association should be performed during installation #126

Open
nyanpasu opened this issue Apr 5, 2015 · 4 comments
Open

File association should be performed during installation #126

nyanpasu opened this issue Apr 5, 2015 · 4 comments

Comments

@nyanpasu
Copy link
Member

nyanpasu commented Apr 5, 2015

Currently association is done in gt::Platform::associate

where the files ~/.local/share/applications/gtorrentt.desktop and ~/.local/share/applications/gtorrentm.desktop are created, generated and written.

After gtorrent gets typically uninstalled by the casual user, these desktop entries remain behind, like unpleasant love marks.

@benwaffle
Copy link
Member

Just add a "use gtorrent by default" button in the settings, and make sure the .desktop files are registered with the package manager so they are uninstalled properly.

@nyanpasu
Copy link
Member Author

nyanpasu commented Apr 5, 2015

The "use gtorrent by default" should be handled by the operating system or whatever file manager you use. e.g: in linux, xdg-mime default $file.desktop mime/info

I forgot to mention, we should have these files should be generated and placed during make install.

I'll see how it's done in other software, but I can't imagine it'd be much different.

@benwaffle
Copy link
Member

as a user i don't want to deal with mime types and whatever
I just want to click a button like in firefox

@nyanpasu
Copy link
Member Author

nyanpasu commented Apr 5, 2015

Ah, I should elaborate.

What I meant though is that most xdg-compliant software will present you with a 'use as default' equivalent option whenever you are asked what program you want to open a filetype with. This achieves to the same effect as what xdg-mime default $file.desktop mime/info does.

You don't have to fuck around with mime types associations yourself, it should be arranged by the program that deals with the 'open with' part of the flow.

gtorrent won't have to make itself a default for the bittorrent, that's up to the end user and how the operating system goes around with it. All that will happen is that gtorrent associates itself with the right filetype during install.

Requests to make an application a default handler may be subject to system policy or approval by the end-user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants