Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version of protoc-gen-swift is mismatched between the macOS and Linux versions of the latest release (1.23.0) #2052

Closed
ezzatron opened this issue Sep 11, 2024 · 4 comments
Labels

Comments

@ezzatron
Copy link

ezzatron commented Sep 11, 2024

Describe the bug

When downloading archives from the 1.23.0 GitHub release, the included version of protoc-gen-swift differs between the macOS and Linux versions:

This is leading to us seeing different generated output under CI vs. when run locally.

To reproduce

See this reproduction repo / workflow run: https://github.com/ezzatron/grpc-swift-binary-version-repro/actions/runs/10804792826

Alternatively, set up a GitHub repo with this workflow, and run it to check the version difference:

on:
  push:

jobs:
  linux:
    runs-on: ubuntu-latest
    steps:
      - run: |
          curl -sSL https://github.com/grpc/grpc-swift/releases/download/1.23.0/protoc-grpc-swift-plugins-linux-x86_64-1.23.0.zip -o protoc-grpc-swift-plugins.zip
          unzip protoc-grpc-swift-plugins.zip
          ./protoc-gen-swift --version
          ./protoc-gen-grpc-swift --version

  macos:
    runs-on: macos-latest
    steps:
      - run: |
          curl -sSL https://github.com/grpc/grpc-swift/releases/download/1.23.0/protoc-grpc-swift-plugins-1.23.0.zip -o protoc-grpc-swift-plugins.zip
          unzip protoc-grpc-swift-plugins.zip
          bin/protoc-gen-swift --version
          bin/protoc-gen-grpc-swift --version

Expected behaviour

The version of protoc-gen-swift should be the same across all architectures for a given release.

Additional information

N/A

@ezzatron ezzatron added the bug label Sep 11, 2024
@glbrntt
Copy link
Collaborator

glbrntt commented Sep 11, 2024

Thanks for filing this, it should be resolved by #2053

@ezzatron
Copy link
Author

ezzatron commented Oct 8, 2024

@glbrntt I tried to verify that this was fixed in 1.24.0, but it seems like the normal archives are completely missing from the GitHub release: https://github.com/grpc/grpc-swift/releases/tag/1.24.0

I also tried with 1.23.1, but ran into this error with the Linux version:

./protoc-gen-swift: symbol lookup error: ./protoc-gen-swift: undefined symbol: $s10Foundation15ContiguousBytesMp

(see https://github.com/ezzatron/grpc-swift-binary-version-repro/actions/runs/11228796504/job/31213284514#step:2:11)

@glbrntt
Copy link
Collaborator

glbrntt commented Oct 8, 2024

Apologies, 1.24.0 was incorrectly tagged. Try 1.24.1 https://github.com/grpc/grpc-swift/releases/tag/1.24.1


This comes from protoc-gen-swift which is from the SwiftProtobuf project and is unrelated:

./protoc-gen-swift: symbol lookup error: ./protoc-gen-swift: undefined symbol: $s10Foundation15ContiguousBytesMp

$s10Foundation15ContiguousBytesMp demangled is "protocol descriptor for Foundation.ContiguousBytes" which is a bit surprising. I'd suggest try to reproduce that issue in isolation and opening an issue against the SwiftProtobuf repo.

@ezzatron
Copy link
Author

ezzatron commented Oct 8, 2024

@ezzatron ezzatron closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants