Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to using math/rand/v2 to get perf enhancements #7293

Open
arvindbr8 opened this issue May 31, 2024 · 6 comments · May be fixed by #7711
Open

Upgrade to using math/rand/v2 to get perf enhancements #7293

arvindbr8 opened this issue May 31, 2024 · 6 comments · May be fixed by #7711
Labels
P2 Status: Help Wanted Type: Feature New features or improvements in behavior

Comments

@arvindbr8
Copy link
Member

Follow up from: #7283 (comment)

Go1.22 introduced a new rand package with a lot of improvements. See: go.dev/blog/randv2.

We would love to update our usages of math/rand once gRPC-go requires Go 1.22 or later.
@arvindbr8 arvindbr8 added Status: Help Wanted P2 Type: Feature New features or improvements in behavior labels May 31, 2024
@arvindbr8 arvindbr8 mentioned this issue May 31, 2024
Merged
@silaselisha
Copy link
Contributor

@arvindbr8 I would like to be assigned this task.

@purnesh42H
Copy link
Contributor

@silaselisha assigned it to you

@easwars
Copy link
Contributor

easwars commented Aug 30, 2024

This is blocked until we bump the minimum Go version supported to 1.22 in our go.mod.

@marcoferrer
Copy link
Contributor

Is switching to randv2 still blocked?

@easwars
Copy link
Contributor

easwars commented Oct 8, 2024

I see that we bumped up our minimum supported Go version to 1.22.7 in #7624. So, this should be unblocked.

@marcoferrer : Would you be interested in making this change? We'll be happy to review. Thanks.

@marcoferrer marcoferrer linked a pull request Oct 8, 2024 that will close this issue
Open
@marcoferrer
Copy link
Contributor

@easwars Sounds good. PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Status: Help Wanted Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multiple: switch to math/rand/v2 marcoferrer/grpc-go
5 participants
@easwars @purnesh42H @arvindbr8 @marcoferrer @silaselisha