-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus metrics label value inconsistency between Go and Java #664
Comments
Hi, thanks for your issue. I don't know that we can change these now unfortunately, it might break existing users. Note that this is just a third party library and you can probably just copy one of the interceptors and change the labels (preserving the license, of course). |
I see. In that case, do you think it's a good idea to allow passing in an option to convert these label values to standardized form (upper case)? It would greatly help us grouping metrics between Go and Java services. |
I suppose we could consider an option. It looks like the logic for this is here:
|
Hi Team,
I've noticed a Prometheus label value inconsistency between Go and Java (java-grpc-prometheus):
e.g. In metrics
grpc_server_handled_total
,For
grpc_type
label, Java is uppercase while go is lower case, e.g. "UNARY" vs "unary"For
grpc_code
label, Java is uppercase while go is camel case, e.g. "UNKNOWN" vs "Unknown"Do you think it's a good idea to have them standardized? I personally prefer the uppercase, but I would love to hear your thoughts on this.
The text was updated successfully, but these errors were encountered: