-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grpc_retry] Broken retry logic on client streaming #497
Comments
Do you mind trying v2 retry and potentially writing unit test to reproduce? That would be super helpful. The data you provides is too little. We don't know where this method is used and how - more info would be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IIUC, this
grpc_retry
for client streaming is just broken ... here is the core retry logic ... where we haveNote that the
wasGood
once it is true ... it will be always true ... hence skipping all retry logic even if there is an error. The retry can take place only if the very first call failed with retry-able errors ...A screenshot from my debug session can demonstrate it more clearly
The text was updated successfully, but these errors were encountered: