Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Playwright workflow #376

Open
ptgott opened this issue Aug 15, 2023 · 0 comments
Open

Fix the Playwright workflow #376

ptgott opened this issue Aug 15, 2023 · 0 comments

Comments

@ptgott
Copy link
Contributor

ptgott commented Aug 15, 2023

I've noticed that:

  • The .github/workflows/playwright.yml workflow either always fails or is always skipped
  • This doesn't stop us from merging gravitational/docs PRs

We should clean up the Playwright workflow so the gravitational/docs GHA pipeline is easier to understand. This could mean either:

  • Getting Playwright tests to pass and ensuring that gravitational/docs PRs block on these tests passing
  • Removing the Playwright workflow altogether
  • Incorporating the Playwright tests into the Storybook test suite (i.e., rewriting these as Storybook tests). Then ensure that our Storybook tests block gravitational/docs PRs if they fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant