New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments as structs? #34

Open

nikis05 opened this issue Jul 25, 2020 · 0 comments

nikis05 commented Jul 25, 2020

Currently arguments are represented as a tuple of name and value. I think they should be refactored as structs.
Arguments:

Convenience of use, less re-typing same type signature. Named fields provide a more readable notation;
Improved consistency with the rest of API, where most of the nodes are represented as structs or enums;
Being able to read the position of an arg, which is currently impossible.

If you find it reasonable I can do a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment