You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of thank you for the work on this plugin! This error is a result of a unique combination of plugins, so could be an edge case, nevertheless here I go:
We use this plugin as well as with https://github.com/mlipscombe/postgraphile-plugin-fulltext-filter. The issue is that the fulltext-filter plugin modifies the args to replace the type on the tsvector columns with a deeply nested object (it contains tokenization information).
As a result, when we update a field of type tsvector (that is manipulated by that plugin) postgraphile-upload exceeds max stack when it dives into it: RangeError: Maximum call stack size exceeded. We feel this is a bug because in this case we are not even trying to upload a file, but the plugin is preventing an update on a different unrelated fields.
I'm not sure what the solution would be, we thought of two options:
Move on when recursion reaches a certain depth
Provide an option to black list certain fields in which case the plugin would not even dive into them to begin with
The object that is we are attempting to update is like:
{
block:false,
kind:'StringValue',
// this is the key that causes max call stack, since both startToken and endToken are deeply nested,
loc:Loc {start: 86, end: 107, startToken: Tok, endToken: Tok, source: Source},
value:'abl:368 accommod:81',
}
Thank you!
The text was updated successfully, but these errors were encountered:
Hi,
First of thank you for the work on this plugin! This error is a result of a unique combination of plugins, so could be an edge case, nevertheless here I go:
We use this plugin as well as with https://github.com/mlipscombe/postgraphile-plugin-fulltext-filter. The issue is that the
fulltext-filter
plugin modifies theargs
to replace the type on thetsvector
columns with a deeply nested object (it contains tokenization information).As a result, when we update a field of type
tsvector
(that is manipulated by that plugin)postgraphile-upload
exceeds max stack when it dives into it:RangeError: Maximum call stack size exceeded
. We feel this is a bug because in this case we are not even trying to upload a file, but the plugin is preventing an update on a different unrelated fields.I'm not sure what the solution would be, we thought of two options:
The object that is we are attempting to update is like:
Thank you!
The text was updated successfully, but these errors were encountered: