Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Grails Bom extend Spring Boot Bom #13785

Closed
codeconsole opened this issue Oct 17, 2024 · 2 comments · Fixed by #13786
Closed

Make Grails Bom extend Spring Boot Bom #13785

codeconsole opened this issue Oct 17, 2024 · 2 comments · Fixed by #13786

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Oct 17, 2024

Since we removed Micronaut and Grails is tied to Spring Boot. The Grails bom should extend the Spring Boot bom. That way any versions recommended and tested by the Spring framework will be inherited by the Grails bom.

Versions can also be overridden in the Grails Bom if they need to be newer or held back, but it is a good starting point for for the developer for any dependencies we are currently not using.

apply plugin: 'maven-publish'
publishing {
publications {
maven(MavenPublication) {
pom.withXml {
def xml = asNode()
def plugins = new Properties()
plugins.load(new StringReader(new File("$projectDir/plugins.properties").text))
def profiles = new Properties()
profiles.load(new StringReader(new File("$projectDir/profiles.properties").text))

https://docs.spring.io/spring-boot/gradle-plugin/managing-dependencies.html

https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-dependencies/

https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-dependencies/3.3.4/spring-boot-dependencies-3.3.4.pom

@matrei
Copy link
Contributor

matrei commented Oct 17, 2024

I think this is a good idea!

@codeconsole
Copy link
Contributor Author

#13787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants