Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider augmenting _Scope to ensure we clear errors after each operation #61

Open
jonasfj opened this issue Nov 2, 2022 · 1 comment
Open

Consider augmenting _Scope to ensure we clear errors after each operation #61

jonasfj opened this issue Nov 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jonasfj
Copy link
Member

jonasfj commented Nov 2, 2022

We wrap all (or almost all) FFI code in _Scope, thus, it might make sense to review all usage of _Scope to see if we can augment _Scope such that that clear errors after an operation is done.

We should be handling errors all the places where they can happen, but as added safety it might be wise to clear errors after each operation and throw an error, if BoringCrypto has an error on the stack that we didn't expect to find there.
@jonasfj jonasfj added the enhancement New feature or request label Nov 2, 2022
@jonasfj
Copy link
Member Author

jonasfj commented Nov 2, 2022

See also: #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasfj