Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade BoringSSL #111

Open
jonasfj opened this issue May 8, 2024 · 0 comments
Open

Upgrade BoringSSL #111

jonasfj opened this issue May 8, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jonasfj
Copy link
Member

jonasfj commented May 8, 2024

We need to upgrade BoringSSL, however, their build scripts have changed a bit. In particular how ASM files are added, so we might need to make some changes.

The logic is in:
https://github.com/google/webcrypto.dart/blob/master/tool/update-boringssl.py

We need to bump BORINGSSL_REVISION.

And then fix our build script generator logic, since asm_outputs parameter isn't give to WriteFiles anymore.

I tried playing with this, but we need to do more than simple remove the asm_outputs parameter.


There is some documentation in: https://boringssl.googlesource.com/boringssl/+/refs/heads/master/INCORPORATING.md

The rest is reading BoringSSL code and build system 🤣

@jonasfj jonasfj added bug Something isn't working help wanted Extra attention is needed labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant