From 37f65ff92acf5b3f02ee8f57cbf7392a601b39f1 Mon Sep 17 00:00:00 2001 From: Jonas Finnemann Jensen Date: Tue, 22 Oct 2024 19:40:37 +0200 Subject: [PATCH] Manually specify firefox location for package:test on macos --- .github/workflows/test.yml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 28cc842f..25444594 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -63,11 +63,11 @@ jobs: run: | flutter config --no-analytics - run: flutter pub get - #- run: flutter pub run webcrypto:setup - #- run: flutter test - #- run: flutter test --platform chrome - #- run: flutter test integration_test/webcrypto_test.dart -d macos - # working-directory: ./example + - run: flutter pub run webcrypto:setup + - run: flutter test + - run: flutter test --platform chrome + - run: flutter test integration_test/webcrypto_test.dart -d macos + working-directory: ./example # TODO: Enable chromdriver testing on MacOS when it works reliably #- uses: nanasess/setup-chromedriver@v2 #- name: Run integration_test with chromedriver @@ -78,8 +78,13 @@ jobs: # --target=integration_test/webcrypto_test.dart \ # -d chrome - uses: browser-actions/setup-firefox@v1 - - run: bash -c 'which firefox' - - run: flutter pub run test -p firefox #vm,chrome # TODO: Enable firefox if it works + - name: flutter pub run test -p vm,chrome,firefox + shell: bash + # Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8 + # Issue is fixed in https://github.com/dart-lang/test/pull/2276 + run: | + export FIREFOX_EXECUTABLE="$(which firefox)" + flutter pub run test -p vm,chrome,firefox windows: name: webcrypto on Windows desktop / Chrome / Firefox runs-on: windows-latest