From 1013ffbbfd733e977d458880000ede2a60f6df39 Mon Sep 17 00:00:00 2001 From: Jonas Finnemann Jensen Date: Wed, 23 Oct 2024 15:22:58 +0200 Subject: [PATCH] Test with firefox on macos again (#163) * Try to find where firefox is installed * Update test.yml * Manually specify firefox location for package:test on macos --- .github/workflows/test.yml | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7c5050f4..30250248 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -77,8 +77,14 @@ jobs: # --driver=test_driver/integration_test.dart \ # --target=integration_test/webcrypto_test.dart \ # -d chrome - # TODO: Enable firefox testing on MacOS when it works - - run: flutter pub run test -p vm,chrome + - uses: browser-actions/setup-firefox@v1 + - name: flutter pub run test -p vm,chrome,firefox + shell: bash + # Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8 + # Issue is fixed in https://github.com/dart-lang/test/pull/2276 + run: | + export FIREFOX_EXECUTABLE="$(which firefox)" + flutter pub run test -p vm,chrome,firefox macos-15: name: webcrypto on macOS 15 desktop / Chrome runs-on: macos-15 # Test with xcode 16 @@ -98,8 +104,14 @@ jobs: - run: flutter test integration_test/webcrypto_test.dart -d macos working-directory: ./example # TODO: Enable chromedriver testing on MacOS when it works reliably - # TODO: Enable firefox testing on MacOS when it works - - run: flutter pub run test -p vm,chrome + - uses: browser-actions/setup-firefox@v1 + - name: flutter pub run test -p vm,chrome,firefox + shell: bash + # Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8 + # Issue is fixed in https://github.com/dart-lang/test/pull/2276 + run: | + export FIREFOX_EXECUTABLE="$(which firefox)" + flutter pub run test -p vm,chrome,firefox windows: name: webcrypto on Windows desktop / Chrome / Firefox runs-on: windows-latest