Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author filter #267

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add author filter #267

wants to merge 1 commit into from

Conversation

aocenas
Copy link

@aocenas aocenas commented Jun 8, 2021

Closes: #192
Maybe also: #264

Adds a regex filter that checks author of a PR so you can do same regex filtering on it as with title. It uses i.GetUser().Login as the string to match (so cannot be used on full name but that does not seem important).

Our usecase for this is to have a table with team PRs and separate ones for external ones. This usecase would also be served by #266 to be honest but I did not notice it before and I think this may still be useful.

The code is just copy pasting existing regex filters code.

This is a draft mainly to check the naming and get some feedback on whether I am forgetting to add something somewhere to make this work consistently, naming etc.

TODO:

  • docs
  • ???

@google-cla
Copy link

google-cla bot commented Jun 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@aocenas aocenas closed this Jun 10, 2021
@aocenas aocenas reopened this Jun 10, 2021
@aocenas
Copy link
Author

aocenas commented Jun 14, 2021

@googlebot I signed it!

@aocenas
Copy link
Author

aocenas commented Jun 18, 2021

Hey, @tstromberg any feedback on this? Or should I change it from draft to regular PR?

@meltsufin
Copy link

@aocenas Thanks for a shoutout to #266. We've been using it for a few weeks now and it's been working great. I'm still waiting for a followup on the PR though.

@RCheesley
Copy link
Contributor

Nice, thanks for making the PR! We have the same need but slightly different use case, we need it to enable us to filter PRs by certain organisations so that other orgs can target those ones for testing (we have rules that you can't test PRs from your own company).

Happy to test if someone could explain in simple terms how to :)

@RCheesley
Copy link
Contributor

@aocenas is there any possibility you could share an example of how you're using this on your panels? Would love to help with testing but without the docs to explain how to implement I'm a bit stuck.

@joeyparrish joeyparrish added the enhancement New feature or request label May 26, 2022
@joeyparrish
Copy link
Member

@aocenas, are you interested in reviving this PR? If so, let's discuss. I've just been made a maintainer of this project, and though I'm new to the codebase, I'd be happy to discuss this and work with you on a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Include/exclude specified authors with a filter
4 participants