Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to distinguish between performance marks and measures #214

Open
nolanlawson opened this issue Jul 2, 2021 · 0 comments · May be fixed by #266
Open

Ability to distinguish between performance marks and measures #214

nolanlawson opened this issue Jul 2, 2021 · 0 comments · May be fixed by #266

Comments

@nolanlawson
Copy link

nolanlawson commented Jul 2, 2021

First off, thanks for maintaining Tachometer! It's a really awesome tool.

This is just a minor issue. Sometimes I like to use this pattern:

performance.mark('foo')
// do something
performance.measure('foo', 'foo')

Unfortunately, if I do this, then I can't use the following in my tachometer.json:

{
  "measurement": [
    {
      "mode": "performance",
      "entryName": "foo"
    }
  ]
}

The reason is that Tachometer doesn't know whether I'm talking about the foo mark or measure. So as soon as it sees the mark, it uses that, rather than waiting for the measure.

Something like this would be great:

{
  "measurement": [
    {
      "mode": "performance",
      "entryName": "foo",
      "entryType": "measure"
    }
  ]
}

In the meantime, the workaround is to use a different name for the mark and the measure.

@aomarks aomarks self-assigned this Sep 25, 2021
@aomarks aomarks moved this to Todo in Lit Project Board Jan 24, 2022
@aomarks aomarks moved this from 🔥 Front Burner to 🧊 Icebox in Lit Project Board Mar 15, 2022
@aomarks aomarks removed their assignment Jun 21, 2022
@aomarks aomarks moved this from 🧊 Icebox to 📋 Triaged in Lit Project Board Jun 21, 2022
@nolanlawson nolanlawson linked a pull request Aug 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants