-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manager: detect lost connection when executor gets killed #5028
Labels
Comments
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
Jul 23, 2024
Pass Type struct directly during registration. This allows to add additional optional parameters to VM types without changing all VM implementations. We we will need to add SupportsSnapshots flag and one flag to resolve google#5028. With this change it will be possible to add "SupportsSnapshots: true" to just one VM type implemenetation.
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
Jul 23, 2024
Pass Type struct directly during registration. This allows to add additional optional parameters to VM types without changing all VM implementations. We we will need to add SupportsSnapshots flag and one flag to resolve google#5028. With this change it will be possible to add "SupportsSnapshots: true" to just one VM type implemenetation.
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
Jul 23, 2024
Pass Type struct directly during registration. This allows to add additional optional parameters to VM types without changing all VM implementations. We we will need to add SupportsSnapshots flag and one flag to resolve google#5028. With this change it will be possible to add "SupportsSnapshots: true" to just one VM type implemenetation.
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 23, 2024
Pass Type struct directly during registration. This allows to add additional optional parameters to VM types without changing all VM implementations. We we will need to add SupportsSnapshots flag and one flag to resolve #5028. With this change it will be possible to add "SupportsSnapshots: true" to just one VM type implemenetation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When fuzzing the USB HID drivers, I noticed that most of the time is being spent on rebooting VMs without any detected crashes and before the normal 1 hour timeout passes:
What happens is that due to #5027, the executor process gets killed all the time due to Ctrl+Alt+Del.
Fixing that issue should solve the problem of executor getting killed, however, I think
syz-manager
needs to detect such cases aslost connection
to allow identifying and fixing them if they happen again in the future (or possibly already happening right now).The reason
syz-manager
ignores the executor getting killed is because the executor printsSYZ-EXECUTOR: PREEMPTED
before exiting:Thus,
extractError
invm/vm.go
just exits on theexecutorPreemptedStr
check.The comment in
executor/executor_runner.h
says that this is related toGCE VM preemption
:But this is not the case here, as I'm using QEMU.
Commenting out the
executorPreemptedStr
check inextractError
makessyz-manager
to detect thelost connection
as expected, but I assume this is not the proper fix.The text was updated successfully, but these errors were encountered: