Prometheus as exporter for SLO-Gen.

[ppothepa24]

I am using Prometheus as the exporter for the SLO-Gen. There are very few metrics that are currently being exported. I wanted to customize the exporter.py files to show other relevant metrics(Error Budget Metrics).. Facing some difficulty and any help would be appreciated.

[lvaylet]

Hi @ppothepa24, feel free to open a new Pull Request (PR) with your changes and we can discuss them there.

[lvaylet]

Hi @ppothepa24, I think I understand what you have in mind. I am just not sure adding the new metrics to base.py is relevant, for two reasons.

The first reason is, we might not want these metrics to be exported by default by all the exporters. This could introduce a breaking change for existing users (even if I agree they are just additions, not updates or deletions) and also incur additional ingestion and storage costs (depending on the exporter).

The second reason is, we made the SLO Generator as flexible and configurable as possible through YAML files and CLI options, so everyone can customize their workflow without impacting the other users.

Have you checked docs/shared/metrics.md? From what I understand, you can add a metrics block to the configuration of your Prometheus exporter and define the metrics you need there. Then the list of metrics is picked up by the exporter at this step:

slo-generator/slo_generator/exporters/base.py

Line 81 in 84d2d4d

metrics = config.get("metrics", DEFAULT_METRICS)

Does that help?