-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: auto fix for fmt and codegen #3232
Comments
Thank you for the suggestion, @spalberg. However, this repo is a bit unusual in that I'm the primary maintainer but have no permissions to actually administer the repo settings myself. I don't know if you have noticed, but we have had an ongoing Codecov issue in this repo where we are relying upon getting support from the organization that actually owns this repo and has the ability to update its token secrets. So although I think this is an idea we might want to try out, this repo is probably not a good fit for it and I'll close the issue. Thanks again, though, @spalberg. Your ideas and contributions are greatly appreciated. |
Just an idea, simply close the issue if it does not make sense to you or its overkill 😃
In order to make sure that the generated files are always up to date without any ping-pong in the pull requests, this project could configure an auto fix workflow using github actions - the same goes for fmt if this is ever an issue or any other automatable tasks.
This can be done using the autofix github app which also works on PRs from forks.
Here is an example for a workflow fixing golang PR: https://autofix.ci/setup#go
Since you seem to squash PRs on merge anyway, the potential extra commits fixing the PR should not matter to the history.
The downsides of this approach are that some people might be confused about automated commits on their PRs and that the app needs to be installed in the github org - although it can be scoped to single repositories, I'm not sure how flexible google is which such things.
The text was updated successfully, but these errors were encountered: