Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address VwG non-interactive flow (token refresh). #439

Open
brnnmrls opened this issue Jun 6, 2024 · 1 comment · Fixed by #426 or #453
Open

Address VwG non-interactive flow (token refresh). #439

brnnmrls opened this issue Jun 6, 2024 · 1 comment · Fixed by #426 or #453
Assignees
Labels
enhancement New feature or request

Comments

@brnnmrls
Copy link
Member

brnnmrls commented Jun 6, 2024

Completing the interactive flow for VwG, one of the next steps is to consider the non-interactive flow. This portion starts whenever the user has already been verified or in the case they need to refresh.

We want to provide requesting parties with the ability to refresh VwG tokens. There's two solutions where one is more suitable timing wise and the other is more complex but addresses two issues regarding the auth state that the first will not:

  1. (easy solution) We will provide the requesting party with an API that holds a method to manage the token refresh. This API will require developers to pass in their refresh token string, which we will use to create the refresh token request.
    • There are two limitations which are addressed by the more complex solution: 1) GSI attaches authorization state holding the tokens on GIDGoogleUser. 2) GSI saves tokens to the device chain.
  2. (complex solution) Adding token refresh to GIDGoogleUser.
@brnnmrls brnnmrls added the enhancement New feature or request label Jun 6, 2024
@brnnmrls brnnmrls self-assigned this Jun 6, 2024
@brnnmrls brnnmrls linked a pull request Jun 6, 2024 that will close this issue
@brnnmrls brnnmrls linked a pull request Jul 9, 2024 that will close this issue
@brnnmrls
Copy link
Member Author

brnnmrls commented Aug 7, 2024

As of #426, we implemented option 1. Design implementation has been started on option 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant