Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off of archived firebase/OCMock SPM dependency #364

Open
redfinwyland opened this issue Jan 26, 2024 · 2 comments
Open

Migrate off of archived firebase/OCMock SPM dependency #364

redfinwyland opened this issue Jan 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@redfinwyland
Copy link

Is your feature request related to a problem you're having? Please describe.

The following dependency in the Package.swift has been archived for over a year by the firebase org:

.package(
      name: "OCMock",
      url: "https://github.com/firebase/ocmock.git",
      .revision("7291762d3551c5c7e31c49cce40a0e391a52e889")),

Describe the solution you'd like

The firebase author forked this from the original repo which appears to fully support SPM now:
https://github.com/erikdoe/ocmock/blob/master/Package.swift

What work would be needed to make this dependency change in this Package to ease dependency resolution in projects that depend on GoogleSignIn?

@redfinwyland redfinwyland added enhancement New feature or request triage Issues that need to be triaged labels Jan 26, 2024
@mdmathias mdmathias removed the triage Issues that need to be triaged label Feb 8, 2024
@mdmathias
Copy link
Collaborator

Hi @redfinwyland and thanks for the issue. Good callout that this dependency is archived. We'd happily accept a PR updating it. We will likely get to it eventually, but it's not at the top of our stack, so to speak.

@redfinwyland
Copy link
Author

@mdmathias Can you please review the attached PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants