-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute URLs hardcoded into markup #109
Comments
not hardcoded. pulls from config.yaml. via tokens inserted into liquid template syntax.
from config.yaml...
|
Ah! Cool ok, I'll look into that, either making it relative or perhaps adding a custom config.yaml for maverick. Is there a particular reason you've moved it to /devFrame rather than . or /? |
did not want to hog root as it probably should be some sort of index to goodrobots projects. eventually. my understanding is to host from root of github org you have to create a separate repo as well. |
likely be best to run a custom config yaml in case someone does want to create a PR from maverick devframe docs. the baseurl property really helps for local dev so you can easily mirror githib setups. |
When trying to load the compiled site through nginx, it fails because links/images/references are all hardcoded with '/devFrame' prefix. URLs should ideally be relative, so the site can be hosted anywhere.
The text was updated successfully, but these errors were encountered: