Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute URLs hardcoded into markup #109

Open
fnoop opened this issue Apr 24, 2020 · 4 comments
Open

Absolute URLs hardcoded into markup #109

fnoop opened this issue Apr 24, 2020 · 4 comments

Comments

@fnoop
Copy link
Member

fnoop commented Apr 24, 2020

When trying to load the compiled site through nginx, it fails because links/images/references are all hardcoded with '/devFrame' prefix. URLs should ideally be relative, so the site can be hosted anywhere.
Screenshot 2020-04-24 at 10 01 05

@cglusky
Copy link
Member

cglusky commented Apr 24, 2020

not hardcoded. pulls from config.yaml. via tokens inserted into liquid template syntax.

[build section]({{ site.baseurl }}/docs/build-intro/)

from config.yaml...

# Site 

locale: "en-US"
title: "devFrame docs"
description: >- # this means to ignore newlines 
"devFrame is an Open Source quadcopter and rover frame design." 
url: "https://goodrobots.github.io"
baseurl: "/devFrame"
stlurl: "/blob/master/stl/"

@fnoop
Copy link
Member Author

fnoop commented Apr 24, 2020

Ah! Cool ok, I'll look into that, either making it relative or perhaps adding a custom config.yaml for maverick. Is there a particular reason you've moved it to /devFrame rather than . or /?

@cglusky
Copy link
Member

cglusky commented Apr 24, 2020

did not want to hog root as it probably should be some sort of index to goodrobots projects. eventually. my understanding is to host from root of github org you have to create a separate repo as well.

@cglusky
Copy link
Member

cglusky commented Apr 24, 2020

likely be best to run a custom config yaml in case someone does want to create a PR from maverick devframe docs. the baseurl property really helps for local dev so you can easily mirror githib setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants