-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass context to TestOnBorrow #439
Comments
Indeed this would require a new method. |
Uh, so, was a new method added? The PR was closed without merging, resulting in this issue being closed. And I don't have permissions to reopen the issue. |
Yes you can see the comments on the #442 |
@dcormier just flagging this was reopened in case you didn't see the notification. Also mentioning that I'm thinking of a v2 which would help clean up the existing interfaces, so would be interested in peoples feedback on use cases like this we should consider when designing that. |
I like to add tracing to my code. This depends on being able to pass a context around. To that end, I wish
TestOnBorrow
was passed the context that's passed toGetContext
. Perhaps this would require a new function so it's not a breaking change:TestOnBorrowContext
, or something similar.The text was updated successfully, but these errors were encountered: