Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip admin and change oidc user not found message more readable #21061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip admin and change oidc user not found message more readable #21061

wants to merge 1 commit into from

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 18, 2024 •
edited
Loading

fixes #21041
verified in local env
Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner October 18, 2024 08:30
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.08%. Comparing base (c8c11b4) to head (06d5924).
Report is 299 commits behind head on main.

Files with missing lines Patch % Lines
src/pkg/oidc/secret.go 0.00% 3 Missing ⚠️
src/server/middleware/security/oidc_cli.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21061       +/-   ##
===========================================
+ Coverage   45.36%   66.08%   +20.71%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114651   +101318     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75769    +69720     
- Misses       6983    34735    +27752     
- Partials      301     4147     +3846
Flag Coverage Δ
unittests 66.08% <0.00%> (+20.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/oidc/secret.go 24.67% <0.00%> (ø)
src/server/middleware/security/oidc_cli.go 63.63% <0.00%> (ø)

... and 1286 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

@chlins chlins

Labels
candidate/2.13.0 release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin, error: failed to get oidc user info, error: <QuerySeter> no row found
4 participants
@stonezdj @wy65701436 @OrlinVasilev @chlins