-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Refactor library into a modernized approach in a new major version #228
Comments
@iMoses This is brilliant. This is exactly the direction I wanted to steer react-collapsible. I wonder if @glennflanagan feels the same way? @glennflanagan What are you thoughts? Would you be happy in making iMoses a contributor? We could create a v3 branch to do some extensive tests on it. |
Yes that is really nice - if we can do the hook version alongside the old class way of doing it too that'd be amazing. I definitely don't have the time to implement something like this - and the amount of work would feel like it'll end up a completely different project. What do you think @karltaylor? |
Yeah I agree with keeping it classes. I think we could collaboratively work on this over next coming months. Perhaps open up a discussions on this repo and ask for some extra helping hands from the community? |
Discussion open here #234 |
Seems like you forgot about it completely, but my suggestion still stands... |
I made a very optimized headless hook version of your library to use in my projects and I wanted to check if you'd like to use the code (or work together to produce something similar). I did remove the ARIA part which can be easily added back in if and when it comes to it.
https://gist.github.com/iMoses/24b9dd6e13a26145a919127d38f8c088
Let me know what you think. If you're not interested I can open a separate package for it, just thought it's worth asking since it is technically your logic and the library could benefit from a new major refactor. I think it's always better to improve the existing options then provide more and more of them :)
The text was updated successfully, but these errors were encountered: