Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires property is missing on MetaInfo #166

Open
naipotato opened this issue Apr 29, 2024 · 1 comment · May be fixed by #216
Open

Requires property is missing on MetaInfo #166

naipotato opened this issue Apr 29, 2024 · 1 comment · May be fixed by #216
Labels
gjs-convention Marks issues for aligning with GJS coding standards and practices

Comments

@naipotato
Copy link

naipotato commented Apr 29, 2024

As can be seen here, GJS takes a Requires property in the meta info object passed to GObject.registerClass when defining interfaces.

I don't really have an idea of the type for this property, other than an array. Perhaps it can be similar to Implements?

@JumpLink JumpLink added the gjs-convention Marks issues for aligning with GJS coding standards and practices label Jun 18, 2024
@JumpLink
Copy link
Collaborator

@naipotato The GitHub search is very useful to find out the type for this :)

Adding corrected types is comparably easy in this case, because many types for the overrides are defined by hand, see: https://github.com/gjsify/ts-for-gir/blob/main/packages/generator-typescript/templates/gjs/gobject-2.0.d.ts#L212

@JumpLink JumpLink linked a pull request Nov 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gjs-convention Marks issues for aligning with GJS coding standards and practices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants