Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for pagination and better filtering among reports #4

Open
rzhade3 opened this issue Aug 21, 2023 · 0 comments
Open

Allow for pagination and better filtering among reports #4

rzhade3 opened this issue Aug 21, 2023 · 0 comments

Comments

@rzhade3
Copy link
Contributor

rzhade3 commented Aug 21, 2023

@bobek:

Hi, I've need to be able to define more extensive filters on reports and also noticed that you don't do pagination, which yield in missing records. I've hacked something quickly in https://github.com/Showmax/hackerone-client/tree/reports-find . It should be considered WIP, for example abstracting pagination out of this methods and actually making it more robust (similarly to your parse_response method).

But I thought that you may be interested in the work.


@oreoshake:

Thanks for the branch! I hadn't even thought about pagination, thankfully our queries always return a small result.

Just some bikesheding: I think we should augment the existing reports method rather than adding a new one.


@bobek:

Just some bikesheding: I think we should augment the existing reports method rather than adding a new one.

I am totally for it. I've just created a new method to separate the code at the moment, before I get some feedback from you.


@esjee:

This is really great! Would you be up for creating a pull request? Is there anything I can do to help you?


@oreoshake:

Just adding a note here that independent of pagination implementation, we should eventually add an auto-paginate feature a la octokit.


Transferred from oreoshake/hackerone-client#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant